[Bug]: FreeBSD rc.d init script sends wrong signal for savedb

[hut8]

Bug description

I just installed via the kickstart script moments ago on FreeBSD. While debugging the immediate segfault I got, I noticed that the rc script has a typo:

netdata_reloadhealth()
{
    p=`cat ${pidfile}`
    kill -USR2 ${p} && echo "Sent USR2 (reload health) to pid ${p}"
    return 0
}

netdata_savedb()
{
    p=`cat ${pidfile}`
    kill -USR2 ${p} && echo "Sent USR1 (save db) to pid ${p}"
    return 0
}

Seems like in netdata_savedb, it should send USR1 based on the message whereas it sends USR2 which "reloads health"

Expected behavior

Running service netdata savedb would send USR1

Steps to reproduce

1. service netdata savedb on FreeBSD as root
2. Wrong signal is sent (or wrong message is displayed)

Installation method

kickstart.sh

System info

FreeBSD supervillain 14.0-RELEASE FreeBSD 14.0-RELEASE #0 releng/14.0-n265380-f9716eee8ab4: Fri Nov 10 05:57:23 UTC 2023     root@releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64
1400097

Netdata build info

I can't actually run it because it segfaults, which is another issue :)

Additional info

No response

[hugovalente-pm]

seems one for @netdata/agent-sre to take a look

[ilyam8]

@hugovalente-pm I think USR1 ("Save internal DB to disk") was only applicable for memory mode save (or for map and save) - this mode was removed in #16604.

[hugovalente-pm]

@ilyam8 ok, do you mean then that this bug is no longer applicable since we don't support those memory modes then?

[ilyam8]

@hugovalente-pm, yes.