Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an include configuration mechanism #2360

Closed
arthurzenika opened this issue Jun 19, 2017 · 8 comments
Closed

Provide an include configuration mechanism #2360

arthurzenika opened this issue Jun 19, 2017 · 8 comments
Assignees
Labels
area/daemon feature request New features priority/high Super important issue

Comments

@arthurzenika
Copy link

It would great if one could modify the configuration of netdata without touching the configuration shipped by the distribution. That way, when upgrades come along, those files are seen as not modified by the upgrade process and you get smoother upgrades, no diffs to read and new options as a bonus.

I don't know if there is a formalisation of this, but the include.d mechanism is great for that. That way we can edit (or ship via salt/ansible/puppet/chef/etc.) atomic files for atomic bits of configuration that don't interfere with the default configuration.

Netdata already uses that for python.d health.d charts.d etc. It would be awesome (or is already the case ?) to be able to have the same for the other configurations:

  • netdata.conf -> add netdata.d/*.conf
  • stream.conf -> add stream.d/*.conf
  • fping.conf -> add fping.d/*.conf
  • etc.
@ktsaou
Copy link
Member

ktsaou commented Jun 22, 2017

Hi,

For sure netdata configuration files have grown quite a bit.

well there are a few requests about /etc/netdata:

There was also a request (I can't find now) about shipping netdata configurations somewhere in /usr and allow the users to overwrite any of them in /etc/netdata.

For sure this requires some more thinking.

For example, it would be great if packages could install/add jobs to specific modules (eg you install a web server and it also installs a file describing a new job for the web_log module of python.d.plugin).

@paulfantom
Copy link
Contributor

Closing as a partial duplicate of #4182.

@ktsaou
Copy link
Member

ktsaou commented Sep 23, 2018

@paulfantom I think we should revisit this when #4182 is implemented. I don't want #4182 to include this one too, because it will be too complex.

So, the idea of this, is to allow splitting config files in multiple parts and add an include directive on all kinds of files. I understand this gives quite some flexibility to users willing to control via their CI pipelines parts of netdata configuration.

My suggestion is to re-open this and do it after #4182.

@stale
Copy link

stale bot commented Nov 23, 2018

Currently netdata team doesn't have enough capacity to work on this issue. We will be more than glad to accept a pull request with a solution to problem described here. This issue will be closed after another 60 days of inactivity.

@stale stale bot added the stale label Nov 23, 2018
@ktsaou
Copy link
Member

ktsaou commented Nov 23, 2018

@l2isbad the request we were talking before, about supporting directories of configuration files for plugin module jobs.

@stale stale bot removed the stale label Nov 23, 2018
@ktsaou ktsaou added the feature request New features label Nov 23, 2018
@ilyam8
Copy link
Member

ilyam8 commented Nov 26, 2018

@cakrit it's not only for python/external modules

@ktsaou
Copy link
Member

ktsaou commented Nov 26, 2018

The motivation and a more generic solution is discussed in #4731

@cakrit cakrit assigned vlvkobal and ilyam8 and unassigned cakrit Jun 20, 2019
@cakrit
Copy link
Contributor

cakrit commented Jul 18, 2019

Closing in favor of #6432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/daemon feature request New features priority/high Super important issue
Projects
None yet
Development

No branches or pull requests

6 participants