Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JMX module] inconsistent use of chart properties 'family' and 'context' #3632

Closed
illes opened this issue Apr 15, 2018 · 1 comment
Closed
Labels
area/collectors Everything related to data collection feature request New features help wanted

Comments

@illes
Copy link
Contributor

illes commented Apr 15, 2018

The usage of family and context in the charts generated by the java.d JMX module does not follow recommendations that may lead to inconsistent UI appearance and inconvenience when integrating with 3rd party tools.

The code at MBeanServerCollector.java#L198 does not seem to follow guidelines set forth in the wiki: https://github.com/firehol/netdata/wiki/External-Plugins#chart

The property family could rather be the identifier of the monitored JVM (serverConfiguration.getName(), the PID by default), and the context some constant across the same charts for different JVMs.

@ilyam8
Copy link
Member

ilyam8 commented Jan 29, 2021

This issue was migrated from netdata-plugin-java-daemon

Closing it because netdata-plugin-java-daemon is not part of the Netdata project.

@ilyam8 ilyam8 closed this as completed Jan 29, 2021
@ilyam8 ilyam8 added area/collectors Everything related to data collection and removed area/external labels Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/collectors Everything related to data collection feature request New features help wanted
Projects
No open projects
Development

No branches or pull requests

4 participants