Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No netdata-updater.sh in cron.daily after installing with kickstart-static64.sh #4122

Closed
cmonty14 opened this issue Sep 6, 2018 · 14 comments · Fixed by #6520
Closed

No netdata-updater.sh in cron.daily after installing with kickstart-static64.sh #4122

cmonty14 opened this issue Sep 6, 2018 · 14 comments · Fixed by #6520
Assignees
Labels
area/packaging Packaging and operating systems support bug priority/medium
Milestone

Comments

@cmonty14
Copy link

cmonty14 commented Sep 6, 2018

Hi,
I have successfully installed netdata on different Linux (SLES 12, Debian 9) with kickstart-static64.sh.

However, there's no file netdata-updater.sh to update this installation.

Question:
How should I update netdata when installing with kickstart-static64.sh?

@ktsaou
Copy link
Member

ktsaou commented Sep 6, 2018

You are right, this is missing.

How should I update netdata when installing with kickstart-static64.sh?

Running kickstart-static64.sh again will update your installation. The only problem is that the daily static build is updated even when there is nothing new to compile. So, if you run this from cron, it will install a fresh netdata even when there is actually nothing new.

So, this is a bug.

@ktsaou ktsaou added the bug label Sep 6, 2018
@ktsaou
Copy link
Member

ktsaou commented Sep 6, 2018

I edited my response above, so read it on github.

@Ferroin
Copy link
Member

Ferroin commented Sep 7, 2018

Hmm...

Not quite sure from looking at the build system, but does Netdata support reproducible builds? If so, then one possibility is to update the build system such that if the code does not change, the hash of the static build does not change, and then the install can store the hash of the build it's installing somewhere, and the updater can compare the two hashes (if they match, there's no need to update).

@ktsaou
Copy link
Member

ktsaou commented Sep 9, 2018

This one builds the latest netdata: https://github.com/firehol/binary-packages/blob/master/build-latest.sh
It is just a daily cron job. Can you adapt it to not rebuild if the tag is the same?

If we fix that, we can then provide an updater for the static build too.

@cakrit
Copy link
Contributor

cakrit commented Sep 19, 2018

I looked at this, it should be a couple of lines only. I'll pick it up as soon as I get my environment straightened out.

@paulfantom paulfantom added area/packaging Packaging and operating systems support OS/installation and removed area/packaging Packaging and operating systems support labels Sep 22, 2018
@paulfantom paulfantom added area/packaging Packaging and operating systems support and removed OS/installation labels Nov 18, 2018
@paulfantom paulfantom self-assigned this Nov 19, 2018
@paulfantom paulfantom added the priority/low A 'nice to have' not critical issue label Nov 19, 2018
@paulfantom paulfantom modified the milestone: v1.12 Jan 3, 2019
@paulfantom paulfantom removed their assignment Mar 5, 2019
@jghaanstra
Copy link
Contributor

Is there any news on this or at least a work around to solve this bug? I installed Netdata with the kickstart-static64.sh script on my CentOS7 VPS and it installed fine in /opt/netdata/ but there is no netdata-updater.sh in either /etc/cron.daily/ or /etc/periodic/ or even somewhere in the Netdata install directory as far as I can tell.

Of course manually running kickstart-static64.sh will update the install but I would like to have auto-updates.

@cakrit cakrit added priority/medium and removed priority/low A 'nice to have' not critical issue labels Jul 10, 2019
@cakrit
Copy link
Contributor

cakrit commented Jul 10, 2019

Apologies @jghaanstra, we've been very busy with the new binary distributions. We'll get to it soon.

@paulkatsoulakis paulkatsoulakis added this to the v1.17-rc1 milestone Jul 15, 2019
@paulkatsoulakis
Copy link
Contributor

Hi @jghaanstra would you mind sharing why you chose static64 instead of the normal kickstart.sh install? CentOS-7 is fully supported from all installation methods

I 'll be taking a look at the issue though regardless of the above

@jghaanstra
Copy link
Contributor

I followed instructions from my hosting company which contains the command for kickstart-static64.sh. Did not really think about it at the time of installing.

Instructions can be found here: https://community.time4vps.com/discussion/352/netdata-get-ready-with-server-monitoring

@paulkatsoulakis
Copy link
Contributor

Hi @jghaanstra, just to get you started, i would recommend to follow Netdata's instructions for installing netdata on a server.

We are in the process of documenting in detail our distribution support matrix too, so that our users can tell what are netdata's capabilities per distribution. I already contacted the author of the above article, so that we get that content aligned with our latest practices too.

Now regarding the static64 installer, we still do need to have a way to keep this up to date.
I 'll keep this issue as development issue to provide auto-update on static64 installer

@paulkatsoulakis paulkatsoulakis modified the milestones: v1.17-rc1, v1.17-rc2 Jul 18, 2019
@cakrit cakrit added the size:2 label Jul 18, 2019
@jghaanstra
Copy link
Contributor

Ok, thanx for the info. Can I just run the default installer to overwrite my current install or are there more steps to take to continue with the default installer method?

@paulkatsoulakis
Copy link
Contributor

Ok, thanx for the info. Can I just run the default installer to overwrite my current install or are there more steps to take to continue with the default installer method?

The clean approach is to first remove the static64 version (you can keep any configs you had done), then run the one-liner kickstart.sh and re-instate your customised configs (if any) on the new paths.

@jghaanstra
Copy link
Contributor

Ok, but what would be the correct approach for removing the static64 version. I have not looked at the script what it does exactly but is it as simple as removing the installation directory or do I also have to do other stuff like remove the netdata user and user group?

@paulkatsoulakis
Copy link
Contributor

you will find the respective uninstaller /opt/netdata/usr/libexec/netdata-uninstaller.sh and you can use that. It will attempt to clean everything up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packaging Packaging and operating systems support bug priority/medium
Projects
No open projects
7 participants