Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish Yoctopuce sensor units PR #6158

Closed
ilyam8 opened this issue May 29, 2019 · 7 comments
Closed

finish Yoctopuce sensor units PR #6158

ilyam8 opened this issue May 29, 2019 · 7 comments
Labels
area/collectors Everything related to data collection collectors/python.d feature request New features good first issue A nice issue that can be handled by first time contributors help wanted new collector Issues to create new collector modules/plugins priority/low A 'nice to have' not critical issue

Comments

@ilyam8
Copy link
Member

ilyam8 commented May 29, 2019

The PR is #4008

Last time I tried to get this working, the issue was with getting python.d
to properly load the Yoctopuce modules. As far as I could tell at the time, the dynamic import thing works, it's just an issue with getting Python to properly import modules that aren't in system.path, but I didn't look very deep beyond that. Part of the problem there is that the Yoctopuce Python modules are not available through most distribution's package managers, which adds a layer of complexity to things.

The actual data collection logic works (I've tested that independently of the plugin itself), so the only issues are the above-mentioned import issue and any possible issues in the chart construction.

Just like #3956 though, I unfortunately don't really have the time to work on this right now. I'll be happy to help when I can (including testing) if someone else wants to work on it.

Originally posted by @Ferroin in #4008 (comment)

So the PR is stuck in WIP. We need some help to finish it!

@ilyam8 ilyam8 added area/external/python help wanted new collector Issues to create new collector modules/plugins labels May 29, 2019
@Ferroin Ferroin added the good first issue A nice issue that can be handled by first time contributors label Dec 24, 2019
@cakrit
Copy link
Contributor

cakrit commented Feb 22, 2020

@Ferroin please see if you can/want to pick this up again, otherwise let's close it.

@Ferroin Ferroin added the priority/low A 'nice to have' not critical issue label Feb 24, 2020
@Ferroin
Copy link
Member

Ferroin commented Feb 24, 2020

I do have interest in it still, I just still (for now) don't really have the time for it. I should, however, have the time to handle it once things settle out after the cloud release, the upcoming switch from Travis to GitHub Actions, and finally getting our Portage overlay for Gentoo done.

I think I actually know now what was causing the issues I saw that prevented me from properly testing this, I just haven't come up with a solution to fix it.

@stale
Copy link

stale bot commented Mar 25, 2020

This issue has been inactive for 30 days. It will be closed in one week, unless it is updated.

@stale stale bot added the stale label Mar 25, 2020
@Ferroin Ferroin added the feature request New features label Mar 26, 2020
@stale stale bot removed the stale label Mar 26, 2020
@Ferroin
Copy link
Member

Ferroin commented Mar 26, 2020

Marking this as a feature request (it technically is) so that it isn't automatically closed.

@crn420

This comment has been minimized.

@crn420

This comment has been minimized.

@crn420

This comment has been minimized.

@ilyam8 ilyam8 closed this as completed Jul 9, 2021
@ilyam8 ilyam8 added collectors/python.d area/collectors Everything related to data collection and removed area/external/python labels Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/collectors Everything related to data collection collectors/python.d feature request New features good first issue A nice issue that can be handled by first time contributors help wanted new collector Issues to create new collector modules/plugins priority/low A 'nice to have' not critical issue
Projects
None yet
Development

No branches or pull requests

5 participants
@Ferroin @ilyam8 @cakrit @crn420 and others