Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin httpcheck heavily changes the WebUI #6530

Closed
It4lik opened this issue Jul 24, 2019 · 6 comments
Closed

Plugin httpcheck heavily changes the WebUI #6530

It4lik opened this issue Jul 24, 2019 · 6 comments
Labels
bug needs triage Issues which need to be manually labelled

Comments

@It4lik
Copy link

It4lik commented Jul 24, 2019

OS : Debian 9.9
Netdata : v1.16.0-70-nightly

Issue : enabling and using python.d httpcheck module causes dashboard layout and behaviour to be unexpectedly modified.

I enabled 5 HTTP Checks with the following configuration :

website:
  name: 'Pretty name'
  url: `https://www.website.com`
  timeout: 3
  update_every: 15

And then refresh netdata configuration.

The new dashboard :

  • has a buggy python.d section at the start
  • does not group HTTP Checks in a group like "HTTP Checks" on chart index (right menu)
  • make all groups of Chart Index buggy : they won't drop down anymore (see on screen 2 how "Memory" is highlighted but no drop-down below it)

Buggy top chart (screen 1) :
netdata1

Buggy/not intuitive chart index (screen 2) :
netdata2

it4.

@It4lik It4lik added bug needs triage Issues which need to be manually labelled labels Jul 24, 2019
@cakrit
Copy link
Contributor

cakrit commented Jul 24, 2019

Please get rid of all special characters in the configuration and see if that solves the issue. Looks like the JS is broken due to probably the single quote I saw in the OP. We definitely need to do something about this, but let's see if that's your issue first.

@It4lik
Copy link
Author

It4lik commented Jul 24, 2019

@cakrit thanks for your quick answer
Indeed. I tried to escape the single quote or quote the whole string with double quotes but that's still broken. Yup if I get rid of it, everything is back to normal.
Works for me, I'll keep it as it is.
And yup, that's pretty unexpected with a "simple" single quote, whether it's properly escaped or double-quoted.

And about grouping : is it possible to group HTTP Checks under their own category (same for docker containers) ?

@cakrit
Copy link
Contributor

cakrit commented Jul 24, 2019

We'd need an additional level to put all cgroups (e.g. docker containers) in a single category. They already contain groups of charts. For httpcheck it's not the same, so we should be able to do it. @ilyam8 ?

Will create a separate issue for the special character handling.

@It4lik
Copy link
Author

It4lik commented Jul 24, 2019

Allright I see. In my opinion it would be great if they can both have their own group, and I'll be manually navigating through the few charts they expose (cpu, ram, net, etc.). But that's totally subjective :)

For httpcheck, you'll face the same problem I think : they are already a category in themselves : they contain the subkeys "response" and "status".

I think grouping these could bring a lot of clarity to a chart index which uses them.
It might also be a behaviour that we could configure in the associated config file.

@ilyam8
Copy link
Member

ilyam8 commented Jul 24, 2019

is it possible to group HTTP Checks under their own category

Well, that is how it is. Every go.d/python.d module (not job) has its own category

Oh, i am wrong. No, it is not possible with current dashboard implementation.

@It4lik
Copy link
Author

It4lik commented Jul 24, 2019

Okay, sounds to me like a limitation to the Netdata dashboard customization. But again, this is purely subjective.
Thanks for all your answers, I'm closing this thread.

@It4lik It4lik closed this as completed Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs triage Issues which need to be manually labelled
Projects
None yet
Development

No branches or pull requests

3 participants