Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CI for macOS #8120

Closed
prologic opened this issue Feb 18, 2020 · 8 comments
Closed

Setup CI for macOS #8120

prologic opened this issue Feb 18, 2020 · 8 comments
Assignees

Comments

@prologic
Copy link
Contributor

As per title. We desperately need to stop getting bitten by *BSD nuances and take BSD more seriously. Let's first off setup CI so PR(s) actually fail if they do not work correctly on *BSD systems.

@prologic prologic added area/ci bug needs triage Issues which need to be manually labelled priority/high Super important issue labels Feb 18, 2020
@amoss amoss removed the needs triage Issues which need to be manually labelled label Feb 23, 2020
@amoss
Copy link
Contributor

amoss commented Feb 23, 2020

If a team member raises the issue I assume it does not require triage :)

@prologic
Copy link
Contributor Author

Probably not 🤣

@Ferroin
Copy link
Member

Ferroin commented Mar 4, 2020

For macOS, the build itself should be done via brew sh.

@prologic
Copy link
Contributor Author

prologic commented Mar 7, 2020

For macOS, the build itself should be done via brew sh.

As mentioned in another PR by @cosmix and myself in person; I didn't even know about brew sh at all :) And I think we should make things work without. It is/wasn't that hard to do and I don't think many users will drop into a brew sh just to run the installer.

@Ferroin
Copy link
Member

Ferroin commented Mar 9, 2020

For macOS, the build itself should be done via brew sh.

As mentioned in another PR by @cosmix and myself in person; I didn't even know about brew sh at all :) And I think we should make things work without. It is/wasn't that hard to do and I don't think many users will drop into a brew sh just to run the installer.

For the installer itself, yeah, people won't run it from brew sh most of the time.

However, I'd be willing to be a a large sum of money that most of our users on macOS are using Homebrew, not the install script, and the build environment that Homebrew uses is equivalent to brew sh.

@prologic
Copy link
Contributor Author

prologic commented Mar 9, 2020

However, I'd be willing to be a a large sum of money that most of our users on macOS are using Homebrew, not the install script, and the build environment that Homebrew uses is equivalent to brew sh.

This is true :)

@prologic prologic added feature request New features and removed bug labels Mar 26, 2020
@prologic
Copy link
Contributor Author

This is not a bug but a feature-request for our CI

@cosmix cosmix added priority/medium and removed priority/high Super important issue labels Apr 29, 2020
@ilyam8 ilyam8 added os/bsd bsd os related issues os/macos macOS os related issues labels May 30, 2020
@cakrit cakrit changed the title Setup CI for FreeBSD, macOS and pfSense Setup CI for macOS Jun 23, 2020
@cakrit
Copy link
Contributor

cakrit commented Jun 23, 2020

Modified to set up CI for MacOS, as we have a different issue for FreeBSD

@Ferroin Ferroin removed the os/bsd bsd os related issues label Oct 26, 2020
@Ferroin Ferroin assigned iigorkarpov and unassigned Ferroin Feb 22, 2022
@Ferroin Ferroin self-assigned this Jul 29, 2022
@ilyam8 ilyam8 added the wontfix label Dec 29, 2023
@ilyam8 ilyam8 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants