Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: performance improvements #17

Open
brunobritodev opened this issue Aug 14, 2021 · 1 comment
Open

Feature: performance improvements #17

brunobritodev opened this issue Aug 14, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@brunobritodev
Copy link
Member

We're seeking for performance improvements. So get a method and write a better version with perf improvemnet.
@brunobritodev brunobritodev added enhancement New feature or request help wanted Extra attention is needed labels Aug 14, 2021
@perf-cat
Copy link

perf-cat commented Mar 3, 2022

Hi @brunohbrito,
Following this issue, I've tried to make some performance optimizations to the OnlyNumbers method in StringExtensions.cs and submitted the following PR (#22) with my changes. I've also included the before and after benchmark summary statistics showing that my changes improve allocations as well as verified that they pass unit tests. I was wondering if you could please review my PR.
I look forward to hearing back from you.
Thank you!
-perf-cat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brunobritodev @perf-cat