Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on Windows 7 due to XINPUT_1.4.DLL dependency #26

Open
Priw8 opened this issue Sep 12, 2020 · 1 comment
Open

Does not work on Windows 7 due to XINPUT_1.4.DLL dependency #26

Priw8 opened this issue Sep 12, 2020 · 1 comment
Assignees
Labels

Comments

@Priw8
Copy link

Priw8 commented Sep 12, 2020

ImGui's example implementation that's used here causes a dependency on XINPUT_1.4.DLL. This version of xinput is not available on Windows 7 and earlier systems, which causes twinhook to error out due to the missing DLL if you're not on Windows 8 or later. An easy fix is making the example use an xinput version that's available on older systems:

imgui_impl_win32.cpp:150:

#pragma comment(lib, "xinput")

change to:

#pragma comment(lib, "xinput9_1_0")

Though, it's probably better to remove the dependency entirely, since I think it's only there because the ImGui example uses it, and twinhook does not actually require xinput at all.

@Netdex
Copy link
Owner

Netdex commented Sep 12, 2020

Thanks for taking the time to debug the issue and report it. The only thing xinput is required for is ImGui navigation with a controller, which you're right about not being used in twinhook. Removing the dependency sounds good to me.

@Netdex Netdex self-assigned this Sep 12, 2020
@Netdex Netdex added the bug label Sep 12, 2020
Netdex added a commit that referenced this issue Sep 12, 2020
deps: shuffle dependency wrapper projects into another directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants