Add support of Hirschmann switch #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeroenvIS
reviewed
Feb 2, 2022
There was a problem hiding this comment.
Looks like a nice start!
A couple of things that you might want to address or clarify:
- There are some references to "3Com" in the file, you probably used that as a starting point? I suggest that you change those.
- Is there a specific reason to define ''h_serial_number'' with a numeric OID? Where possible we prefer to load the right MIBs and resolve the OID via leaf name.
- Can you please put in some comments around the ''model'' logic? Without comments, it doesn't make sense that the model is 'RS40-30' if $model is undefined or if $model contains 'rs30'.
- Is there a specific reason to override the mac() method? For a layer 2 device, I would expect the one from Layer2.pm / Bridge.pm would work. Just curious.
- If the mac() override is indeed needed, please document it in the POD section.
|
I've made the needed corrections. I hope that will be enough |
Add SNMP::Info::Layer2::Hirschmann
release 3.84
|
thank you @Infopromt and @JeroenvIS ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.