-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit 2.0 rules for deprecation or inclusion in 3.0 #19
Comments
Assessment of rules still needing consideration:
|
Note:
These may have been relaxed from error to warning in order to ensure former versions of ESLint would not bomb out in their occurrence (vs continue parsing) |
@theengineear I know it's a lot to review but there's no specific urgency here. I'm looking for a cross-check on my disposition of the rules to be dis/included in 3.0 — my hope is to slim this thing down and not leave anyone in the lurch who wants to upgrade |
Going to just mark this one-by-one and keep returning to this comment as I go:
👍 ➖ camelcase 👎 ➖ curly
🤔 ➖ dot-notation
👍 ➕ guard-for-in 👍 ➖ new-cap 🤔 ➖ no-bitwise
👍 ➕ no-caller 👍 ➖ no-empty 👍 ➕ no-eval 👍 ➕ no-extend-native 👍 ➖ no-iterator 👍 ➖ no-lone-blocks 👍 ➕ no-loop-func
👍 ➖ no-multi-str 👍 ➖ no-new 👍 ➖ no-plusplus 👍 ➕ no-proto 👍 ➕ no-script-url 🤔 ➖ no-sequences
👍 ➖ no-template-curly-in-string 👍 ➖ prefer-spread 👍 ➖ prefer-template 👍 ➖ strict |
@klebba — That was a lot of documentation reading! I mostly agree with your sentiment (thanks for writing in a way that was easy to review, by the way!). There are just a handful of things that I may disagree on. |
Thanks for the review; I'll incorporate your feedback / respond soon and ping back here |
Reconciling our comments so far, here are the items still needing to settle:
|
Sounds good to me @klebba! I agree with your summaries above 👌 |
Addressed by #21 |
2.0 formatting rules removed in 3.0 (deprecated by ESLint)
2.0 rules now covered by
eslint:recommended
in 3.0warning
override, nowerror
pereslint:recommended
)warning
override, nowerror
pereslint:recommended
)2.0 rules carried forward to 3.0
2.0 rules removed in 3.0 (rationale below)
3.0 rules added
The text was updated successfully, but these errors were encountered: