Server-side 500 should occur if a route does not return a value it matched

[jhusain]

We should return a 500 here to avoid retrying endless numbers of times for a request that will never be satisfied.

Note that this error only occurs when a route is matched but the route returns no data.

We should also log to the console exactly which were expected to be found, but not found.

[ThePrimeagen]

This needs to be better explained as there are many edge cases and the router itself does not 500, it can only onNext & onCompleted | onError.

[jhusain]

The router returns an Observable for all of its requests: call, get, and set. All you have to do is make sure it onErrors. It is the servers responsibility to return a 500

JH

On May 20, 2015, at 8:20 AM, Michael Paulson notifications@github.com wrote:

This needs to be better explained as there are many edge cases and the router itself does not 500, it can only onNext & onCompleted | onError.

—
Reply to this email directly or view it on GitHub.

[ThePrimeagen]

That seems a little harsh. Maybe we should consider something different as imagine the following.

router.get([['videos', [123, 456, 678], 'title']])

// This returns
{
    jsong: {
        videos: {
            123: { title: 'HoC' },
            456: { title: 'OITNB' }
        }
    }
}

// Should we really throw?

[ThePrimeagen]

This is a bad idea.