set.toPathValues should dedupe

[ThePrimeagen]

After talking through how set.toPathValues.progressively should work with @jhusain we realized that core.set should dedupe values. When the first set happens, with an onNext function provided, the core should call onNext every value it finds. If the model has _dedupePathValues flag set, the onNext function should only onNext if the value coming in from set is different that the value in the cache.

@trxcllnt does that sound reasonable?

[trxcllnt]

@michaelbpaulson @jhusain do you anticipate this has an impact on the set*asPathValues methods? If so, how should we compare leaves wrt to metadata and values? I remember we toyed around with this idea earlier on and decided against, because it's difficult to meaningfully diff unknown datasets without exposing a comparator (which I'm not necessarily against).

[jhusain]

A comparator make sense to me. Otherwise we can use ===.

JH

On Apr 9, 2015, at 7:28 PM, Paul Taylor notifications@github.com wrote:

@michaelbpaulson @jhusain do you anticipate this has an impact on the set*asPathValues methods? If so, how should we compare leaves wrt to metadata and values? I remember we toyed around with this idea earlier on and decided against, because it's difficult to meaningfully diff unknown datasets without exposing a comparator (which I'm not necessarily against).

—
Reply to this email directly or view it on GitHub.

[ktrott]

Falcor meeting:

@michaelbpaulson : In set toPathValues just doesn't make sense. get double everything you do.

@trxcllnt : set the things in the cache locally, do the network request and onNext what the network request returns

@michaelbpaulson : I want the set to occur immediately on the client. But weird to be onNexted twice when the server response comes back.

Needs more discussion as everyone seems a bit confused on how things are supposed to work.

[jhusain]

The right answer here is to dedupe values. Only onNext when value changes after server response comes back. For custom comparison we can use the compared API introduced for the observe method.

[ktrott]

We would use the same comparer function being added for #91

[ktrott]

Related to issue #170