Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to newer rx version #61

Closed
mbossenbroek opened this issue Sep 15, 2014 · 1 comment
Closed

Upgrade to newer rx version #61

mbossenbroek opened this issue Sep 15, 2014 · 1 comment
Labels

Comments

@mbossenbroek
Copy link
Contributor

The version of rx used today has a broken unsubscribe mechanism, which causes load-* operators to continue to load on background threads infinitely. Update to newer rx version & fix that issue.

@mbossenbroek
Copy link
Contributor Author

Also, it seems that something is holding onto the head of seqs. The primary use of local mode if integration testing, not processing data, but this should be fixed when rx is upgraded.

daveray added a commit to daveray/PigPen that referenced this issue Sep 16, 2014
This is a cursory upgrade and could be taken further. The tests all
pass, but I want to make sure this really works before cleaning up
further.
mbossenbroek added a commit that referenced this issue Sep 22, 2014
* master:
  Update readme
  Update readme
  [Gradle Release Plugin] - new version commit:  '0.2.11-SNAPSHOT'.
  [Gradle Release Plugin] - pre tag commit:  '0.2.10'.
  Update dependencies
  Clean up unsubscription
  Use array-map for tests
  Require ns before protocol
  Remove load-pig & store-pig
  Update more code to use rx bindings. Remove *max-load-records*!
  Update rx for #61

Conflicts:
	pigpen-core/build.gradle
	pigpen-pig/src/main/clojure/pigpen/io.clj
	pigpen-pig/src/test/clojure/pigpen/io_test.clj
	pigpen-pig/src/test/clojure/pigpen/local_test.clj
mbossenbroek added a commit that referenced this issue Sep 22, 2014
* sans-pig:
  Move pigpen.oven back to pigpen-core
  Rename pigpen.local -> pigpen.pig-rx
  Update readme
  Update readme
  [Gradle Release Plugin] - new version commit:  '0.2.11-SNAPSHOT'.
  [Gradle Release Plugin] - pre tag commit:  '0.2.10'.
  Update dependencies
  Clean up unsubscription
  Use array-map for tests
  Require ns before protocol
  Remove load-pig & store-pig
  Update more code to use rx bindings. Remove *max-load-records*!
  Move tuples & bags to post-processing & the UDF. Move exec to runtime.
  Move pigpen.pig/args->map and pigpen.pig/debug to pigpen.runtime
  Use multimethods for serialization. Each platform implements these.
  Update code$ to not refer to pig classes. Using keywords instead
  Move pigpen.pig/eval-string to pigpen.runtime
  Update rx for #61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant