-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is the best way to shim Servo-enabled Metrics / Monitoring into Karyon #150
Comments
I forwarded your question to Nitesh who does more with Karyon. Internally there are some metrics that come for free, but there are also some controls to allow for customization. For example to avoid metrics bloat we may only want metrics indicating the behavior of /api/foo as an aggregate and not /api/foo/${id}. I assume this is similar with the open source version, but Nitesh could give you a better answer. |
"Internally there are some metrics that come for free" ----> I want to On Tue, Apr 16, 2013 at 10:59 AM, brharrington notifications@github.comwrote:
|
Karyon does not really support the runtime aspects of service development as yet. So, it does not clearly provide any hooks or metrics related to service invocations. If you wish to do so, you would typically use a servlet filter to intercept the requests and provide the metrics you want. |
Interesting. Okay, thanks. On Tue, Apr 16, 2013 at 12:01 PM, Nitesh Kant notifications@github.comwrote:
|
+1 for this feature being added to karyon, Nitesh. I understand the metrics-bloat argument, but it would be nice to enable/disable these metrics at the karyon level. perhaps I can pick this task up. I'll work with you offline, Nitesh. @robert: my fluxcapacitor project (https://github.com/cfregly/fluxcapacitor) explicitly adds these metrics directly into the edge and middletier service methods. thanks! -Chris On Apr 16, 2013, at 12:18 PM, Robert Christian notifications@github.com wrote:
|
Thanks Chris. By edge do you mean class where the endpoint (jersey) is On Tue, Apr 16, 2013 at 12:31 PM, Chris Fregly notifications@github.comwrote:
|
correct - they are domain classes and not karyon framework classes, to be clear for others that may be following, the 2 domain classes that https://github.com/cfregly/fluxcapacitor/blob/master/flux-edge/src/main/java/com/fluxcapacitor/edge/jersey/resources/EdgeResource.java these track request-level metrics that would best be replaced by a karyon I'll create an issue under the karyon project for traceability. at i'm pretty sure this is on the roadmap as this servlet-filter is used good catch, Robert! -Chris On Apr 16, 2013, at 12:40 PM, Robert Christian notifications@github.com Thanks Chris. By edge do you mean class where the endpoint (jersey) is On Tue, Apr 16, 2013 at 12:31 PM, Chris Fregly notifications@github.comwrote:
— |
I closed this since this is not a Servo specific issue. |
For example, suppose before HelloWorldResource is encounted at Runtime in Karyon, a filter containing (ie) https://github.com/Netflix/servo/blob/master/servo-core/src/main/java/com/netflix/servo/examples/JvmMetricExample.java is run to keep track of all bytes in/out, etc for all Resources.
Basically we want to say "HelloWorldResource is your stub, and you get metrics and monitoring for free..."
Thanks
The text was updated successfully, but these errors were encountered: