Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timers should protect against negative values that are recorded #191

Closed
brharrington opened this issue Oct 14, 2013 · 1 comment
Closed

Comments

@brharrington
Copy link
Contributor

BasicTimer (and probably others like StatsTimer) do not current prevent negative values from getting recorded. This can happen if say the clock source is not monotonic and there is an ntp adjustment. This will cause an incorrect total time to show up.

Negative values should be ignored, maybe logged so the user will know, though I worry about having logging in the record call if it is used as part of a really tight loop.

@brharrington
Copy link
Contributor Author

Fixed in #209.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant