Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace filter #140

Closed
fraborg opened this issue Apr 3, 2020 · 2 comments · Fixed by #149
Closed

Namespace filter #140

fraborg opened this issue Apr 3, 2020 · 2 comments · Fixed by #149
Labels
help wanted Extra attention is needed kind/feature New feature or request sig/api

Comments

@fraborg
Copy link
Contributor

fraborg commented Apr 3, 2020

The filter on namespace at the moment is very simple: we only use a namespacePrefix argument which allows to run the reconcile method only on LabInstances in the namespaces with that prefix.
It would be nice to have a more generic whitelist, for example something similar to matchLabels used by kubernetes.
@palexster is working on this in #149

@fraborg fraborg mentioned this issue Apr 3, 2020
5 tasks
@fraborg fraborg added kind/feature New feature or request help wanted Extra attention is needed sig/api labels Apr 3, 2020
@frisso
Copy link
Member

frisso commented Apr 6, 2020

@fraborg Can you please add some more details? In your opinion, how the filter should work?

@palexster
Copy link
Member

The previous namespace filter is now superseded by a whitelist selector. Each instance of an operator will handle only the instances of namespaces with specific labels (e.g.; production=true). This would allow to have multiple operator running on the cluster without incurring in cross-talk issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/feature New feature or request sig/api
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants