This repository has been archived by the owner on Oct 18, 2022. It is now read-only.
[CRAI-363] Update README.md for public repository #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rad3ks
reviewed
Jan 9, 2019
README.md
Outdated
| Subsclass `CarLensCollectionViewCell` and call `configure(topView: UIView, cardView: UIView)` right on the start! | ||
| ```swift | ||
| class CarListCollectionViewCell: CarLensCollectionViewCell { | ||
| override init(frame: CGRect) { |
There was a problem hiding this comment.
Not sure if this is the right indentation, but it's just a minor detail to me.
There was a problem hiding this comment.
I also thought so. These are default Github tabs. Will change them for spaces :)
|
|
||
| ## Related repositories | ||
| ## Related links |
README.md
Outdated
| * [Anna-Mariia Shkarlinska](mailto:anna-mariia.shkarlinska@netguru.co) - iOS Developer | ||
| That's what you can do with **CarLensCollectionViewLayout**: | ||
| <p align="center"> | ||
| <img src="https://user-images.githubusercontent.com/18245585/50694808-2b795e80-103b-11e9-839d-f2d8dc533bb4.gif" width="250"> |
There was a problem hiding this comment.
There's a strange white space area before width=. Do you think it could be changed?
rad3ks
approved these changes
Jan 9, 2019
akashivskyy
suggested changes
Jan 9, 2019
| The beautiful animation of collection view cells. | ||
|  | ||
|  | ||
|  |
There was a problem hiding this comment.
Have you made the Bitrise "app" public?
There was a problem hiding this comment.
Good point, not yet!
akashivskyy
approved these changes
Jan 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
CRAI-363
Task Description
Previously the README.md was written for the purpose of an internal project.
Now it's updated for OSS.
You can take a look at it here.