Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate source to Swift 3.0 #13

Closed
akashivskyy opened this issue Jul 17, 2016 · 4 comments
Closed

Migrate source to Swift 3.0 #13

akashivskyy opened this issue Jul 17, 2016 · 4 comments
Assignees
Milestone

Comments

@akashivskyy
Copy link
Collaborator

Source files should be migrated to Swift 3.0. API should be updated to conform to Swift API Guidelines, potentially breaking source compatibility. ¯_(ツ)_/¯

@sxua
Copy link

sxua commented Sep 15, 2016

Hi guys, do you have any ETA for Swift 3 compatible version?

@akashivskyy
Copy link
Collaborator Author

No, but I think we'll start working on that next week. I'll keep you updated. 🙂

@akashivskyy akashivskyy added this to the 1.0 milestone Dec 29, 2016
@akashivskyy akashivskyy self-assigned this Dec 29, 2016
@serejahh
Copy link
Contributor

serejahh commented Jan 20, 2017

Hi @akashivskyy! I'm working on the issue. Existing code base is already migrated, now I'm fixing tests and then I'm gonna update API to be more Swifty. While fixing tests, I got a failed ConsoleOutputFacilitySpec tests. As far as I understood you rely on objects order in dictionary. It fails because headers have different order:
actual:

"X-Baz": "qux"
"X-Foo": "bar",

expected:

"X-Foo": "bar",
"X-Baz": "qux"

@akashivskyy
Copy link
Collaborator Author

I'm working on the issue. Existing code base is already migrated, now I'm fixing tests and then I'm gonna update API to be more Swifty.

Fantastic! ✨

As far as I understood you rely on objects order in dictionary. It fails because headers have different order:

Yeah, I agree that was kind of dumb on my side. If you'd like to change how the test behaves, feel free to do so. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants