Add support for audio ops (Spectrogram & MFCC) in Coreml and add trained coreml model #103
Conversation
… implementation based on parameters
… crying baby detected state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks effitient, good job!
My main 2 issues are short variable names and lack of documentation. Coming from scripting languages like python I understand the urge to implement stuff quickly and caring only if it works. Hovewer now this code is becoming part of a bigger project with interconnected parts. It's very likely that somebody will come back to this code in a couple of months to change something, so it's crutial to make it as understandable as possible.
Because of that, apart from the comments I would like to ask you to add commented doccumentation of the classes and methods. Commenting individual lines inside a method is great too, but doing it for methods in general tells you if you should look into this method or not. Try to give as much info as you can in there - not only saying what this methods does (if it's named correctly, it should convey this by itself), but also what does it mean, how is it connected to other things and more.
Let me know what you think :)
Baby Monitor/Source Files/Services/CryingDetection/AudioMicrophoneService.swift
Show resolved
Hide resolved
Baby Monitor/Source Files/Services/CryingDetection/AudioMicrophoneService.swift
Show resolved
Hide resolved
Baby Monitor/Source Files/Services/CryingDetection/AudioMicrophoneService.swift
Show resolved
Hide resolved
Baby Monitor/Source Files/Services/CryingDetection/CryingDetectionService.swift
Outdated
Show resolved
Hide resolved
Baby Monitor/Source Files/Services/CryingDetection/CryingDetectionService.swift
Outdated
Show resolved
Hide resolved
Baby Monitor/Source Files/Services/MediaPlayer/MicrophoneFactory.swift
Outdated
Show resolved
Hide resolved
Baby Monitor/Source Files/Services/MediaPlayer/NodeCapture.swift
Outdated
Show resolved
Hide resolved
Baby Monitor/Source Files/Services/MachineLearning/AudioSpectrogramLayer.swift
Outdated
Show resolved
Hide resolved
…erate source files
…ice and microphoneCaptureService to better reflect their true purpose
…for more clarity on the purpose
…AudioMicrophoneService
Zamach stanu, przejmuję tego PR. 😆
Woah, that's illegal! |
This PR contains the following additions to the app:
As indicated, this PR is Work in Progress. Specifically the following still has to be done:
PeerConnectionFactoryProtocol.swift:30
to see the the temporary fix that I found)