Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to different presets to share code #9

Open
pkozielecki opened this issue Oct 16, 2020 · 0 comments
Open

Allow to different presets to share code #9

pkozielecki opened this issue Oct 16, 2020 · 0 comments

Comments

@pkozielecki
Copy link

pkozielecki commented Oct 16, 2020

As is:

For now, when we want to add preset-specific code to a stage, we need to duplicate common code for all the presets, eg.:

report:
    default:
        - sh:
            command: "bundle exec danger"
        - copy_artifacts:
            path: $(ENV:BITRISE_DEPLOY_DIR)
    staging:
        - sh:
            command: "bundle exec danger"
        - sh:
            command: "preset-specific command"
        - copy_artifacts:
            path: $(ENV:BITRISE_DEPLOY_DIR)
    clientqa:
        - sh:
            command: "bundle exec danger"
        - sh:
            command: "preset-specific command"
        - copy_artifacts:
            path: $(ENV:BITRISE_DEPLOY_DIR)_

As it should be:

There should be a way to define a common code for all the presets within a given stage:

report:
    common:
        - sh:
            command: "bundle exec danger"
        - copy_artifacts:
            path: $(ENV:BITRISE_DEPLOY_DIR)
    staging:
        - sh:
            command: "preset-specific command"
    clientqa:
        - sh:
            command: "preset-specific command"_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant