fix(classroom): fix user join room race condition (#579)

netless-io · Apr 23, 2021 · 2d28915 · 2d28915
1 parent dce8ee6
commit 2d28915
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 5 deletions.
diff --git a/desktop/renderer-app/src/stores/ClassRoomStore.ts b/desktop/renderer-app/src/stores/ClassRoomStore.ts
@@ -471,10 +471,11 @@ export class ClassRoomStore {
 
         await this.whiteboardStore.joinWhiteboardRoom();
 
-        channel.on("MemberJoined", userUUID => {
-            // not use errorTips function (because there is no need)
-            this.users.addUser(userUUID).catch(console.warn);
-        });
+        // add user on RequestChannelStatus
+        // channel.on("MemberJoined", userUUID => {
+        //     // not use errorTips function (because there is no need)
+        //     this.users.addUser(userUUID).catch(console.warn);
+        // });
         channel.on("MemberLeft", this.users.removeUser);
 
         this.onRTCEvents();
@@ -723,8 +724,10 @@ export class ClassRoomStore {
             }
         });
 
-        this.rtm.on(RTMessageType.RequestChannelStatus, (status, senderId) => {
+        this.rtm.on(RTMessageType.RequestChannelStatus, async (status, senderId) => {
             if (status.roomUUID === this.roomUUID) {
+                // not use errorTips function (because there is no need)
+                await this.users.addUser(senderId).catch(console.warn);
                 this.users.updateUsers(user => {
                     if (user.userUUID === senderId) {
                         if (this.users.creator && user.userUUID === this.users.creator.userUUID) {
@@ -733,6 +736,7 @@ export class ClassRoomStore {
                         }
                         user.camera = status.user.camera;
                         user.mic = status.user.mic;
+
                         return false;
                     }
                     return true;

diff --git a/desktop/renderer-app/src/stores/UserStore.ts b/desktop/renderer-app/src/stores/UserStore.ts
@@ -182,8 +182,20 @@ export class UserStore {
         if (user.userUUID === this.ownerUUID) {
             this.creator = user;
         } else if (user.isSpeak) {
+            const index = this.speakingJoiners.findIndex(
+                ({ userUUID }) => userUUID === user.userUUID,
+            );
+            if (index >= 0) {
+                this.speakingJoiners.splice(index, 1);
+            }
             this.speakingJoiners.push(user);
         } else if (user.isRaiseHand) {
+            const index = this.handRaisingJoiners.findIndex(
+                ({ userUUID }) => userUUID === user.userUUID,
+            );
+            if (index >= 0) {
+                this.handRaisingJoiners.splice(index, 1);
+            }
             this.handRaisingJoiners.push(user);
         } else {
             this.otherJoiners.push(user);