fix(ci): code check ci failed (#682)

* fix(flat-components): redundant cli option in build-storybook * fix(ci): miss flat-i18n package in workspace * fix(flat-components): remove useless package
netless-io · May 28, 2021 · 958738b · 958738b
1 parent d562c09
commit 958738b
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 6 deletions.
diff --git a/desktop/renderer-app/webpack/webpack.common.js b/desktop/renderer-app/webpack/webpack.common.js
@@ -4,7 +4,6 @@ const threadLoader = require("thread-loader");
 const DotenvFlow = require("dotenv-flow-webpack");
 const ESLintPlugin = require("eslint-webpack-plugin");
 const TerserPlugin = require("terser-webpack-plugin");
-const nodeExternals = require("webpack-node-externals");
 const HtmlWebpackPlugin = require("html-webpack-plugin");
 const ForkTsCheckerWebpackPlugin = require("fork-ts-checker-webpack-plugin");
 

diff --git a/packages/flat-components/package.json b/packages/flat-components/package.json
@@ -21,8 +21,8 @@
     "storybook": "start-storybook -p 6006 --no-version-updates",
     "build": "yarn run cleanup && rollup -c",
     "build:esbuild": "node scripts/run-esbuild.js",
-    "build-storybook": "build-storybook --no-version-updates && node scripts/move-storybook.js",
-    "deploy-storybook": "yarn run build-storybook --no-version-updates && node scripts/deploy-storybook.js",
+    "build-storybook": "build-storybook && node scripts/move-storybook.js",
+    "deploy-storybook": "yarn run build-storybook && node scripts/deploy-storybook.js",
     "cleanup": "rimraf ./build"
   },
   "dependencies": {

diff --git a/scripts/ci/install-changed-package-dependencies.js b/scripts/ci/install-changed-package-dependencies.js
@@ -16,19 +16,29 @@ if (isTrue(types)) {
 }
 
 if (isTrue(components)) {
-    workspaces.push("packages/flat-types", "packages/flat-components");
+    workspaces.push("packages/flat-i18n", "packages/flat-types", "packages/flat-components");
 }
 
 if (isTrue(renderer)) {
-    workspaces.push("packages/flat-types", "packages/flat-components", "desktop/renderer-app");
+    workspaces.push(
+        "packages/flat-i18n",
+        "packages/flat-types",
+        "packages/flat-components",
+        "desktop/renderer-app",
+    );
 }
 
 if (isTrue(main)) {
     workspaces.push("packages/flat-types", "desktop/main-app");
 }
 
 if (isTrue(flatWeb)) {
-    workspaces.push("packages/flat-types", "packages/flat-components", "web/flat-web");
+    workspaces.push(
+        "packages/flat-i18n",
+        "packages/flat-types",
+        "packages/flat-components",
+        "web/flat-web",
+    );
 }
 
 workspaces = Array.from(new Set(workspaces));