Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): code check ci failed #682

Merged
merged 3 commits into from
May 28, 2021
Merged

fix(ci): code check ci failed #682

merged 3 commits into from
May 28, 2021

Conversation

BlackHole1
Copy link
Collaborator

  1. remove redundant cli option in build-storybook
  2. add flat-i18n package om workspace
  3. remove webpack-node-externals in renderer-app

@BlackHole1 BlackHole1 merged commit 958738b into main May 28, 2021
@BlackHole1 BlackHole1 deleted the fix-code-check-ci-fail branch May 28, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crimx crimx crimx approved these changes

@hyrious hyrious hyrious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BlackHole1 @crimx @hyrious