feat(whiteboard): support multi window #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheerego7
force-pushed
the
feat-support-multi-window
branch
from
47ce598
to
2c7721c
Compare
crimx
approved these changes
Aug 26, 2021
crimx
requested changes
Aug 26, 2021
BlackHole1
requested changes
Aug 26, 2021
| left: 76px; | ||
| z-index: 3; | ||
| bottom: 8px; | ||
| &.is-disabled { |
There was a problem hiding this comment.
Suggested change
| &.is-disabled { | |
| &.invisible { |
| border-radius: 2px; | ||
| &:hover { | ||
| background: rgba(33, 35, 36, 0.1); | ||
| &.is-disabled { |
There was a problem hiding this comment.
Suggested change
| &.is-disabled { | |
| &.invisible { |
| <div className="redo-undo-box"> | ||
| <div | ||
| className={classNames("redo-undo-box", { | ||
| "is-disabled": whiteboardStore.isWindowMaximization, |
There was a problem hiding this comment.
Suggested change
| "is-disabled": whiteboardStore.isWindowMaximization, | |
| "invisible": whiteboardStore.isWindowMaximization, |
There was a problem hiding this comment.
We use is- prefix to indicate state classnames.
| </div> | ||
| <div | ||
| className={classNames("page-controller-box", { | ||
| "is-disabled": whiteboardStore.isWindowMaximization, |
There was a problem hiding this comment.
Suggested change
| "is-disabled": whiteboardStore.isWindowMaximization, | |
| "invisible": whiteboardStore.isWindowMaximization, |
Comment on lines
362
to
366
| if (this.room && this.windowManager) { | ||
| this.preloadPPTResource.cancel(); | ||
| this.windowManager.destroy(); | ||
| this.room.callbacks.off(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (this.room && this.windowManager) { | |
| this.preloadPPTResource.cancel(); | |
| this.windowManager.destroy(); | |
| this.room.callbacks.off(); | |
| } | |
| this.preloadPPTResource.cancel(); | |
| this.windowManager?.destroy(); | |
| this.room?.callbacks.off(); |
Comment on lines
+375
to
+374
| private scenesPathName = (scenePath: string): string => { | ||
| const cells = scenePath.split("/"); | ||
| const popCell = cells.pop(); | ||
| if (popCell === "") { | ||
| cells.pop(); | ||
| } | ||
| return cells.join("/"); | ||
| }; |
There was a problem hiding this comment.
What does this mean? Can you give me an example of what the value of scenePath looks like?
| left: 76px; | ||
| z-index: 3; | ||
| bottom: 8px; | ||
| &.is-disabled { |
Cheerego7
force-pushed
the
feat-support-multi-window
branch
from
2c7721c
to
5563f32
Compare
Cheerego7
force-pushed
the
feat-support-multi-window
branch
from
5563f32
to
8c6921b
Compare
Cheerego7
added a commit
that referenced
this pull request
Sep 3, 2021
Cheerego7
added a commit
to Cheerego7/flat
that referenced
this pull request
Sep 3, 2021
Cheerego7
added a commit
to Cheerego7/flat
that referenced
this pull request
Sep 3, 2021
Cheerego7
added a commit
that referenced
this pull request
Sep 3, 2021
BlackHole1
added a commit
that referenced
this pull request
Sep 3, 2021
* feat(whiteboard): support multi window (#896) * refactor(desktop): set aspect ratio to 16/9 (#899) * feat(whiteboard): add containerSizeRatio config in windowManager (#900) * chore(ci): add dev branch to check action (#901) * fix(whiteboard): adjust location of collectorContainer element (#903) * refactor(whiteboard): remove vision control (#907) * refactor(whiteboard): remove Vision control * fix(ci): build web and renderer failed * chore(library): upgrade window-manager (#919) * fix(web): should close local tracks on exiting room (#920) * refactor(whiteboard): adjust class room style of whiteboard (#921) * refactor(whiteboard): adjust class room style of whiteboard * fix(type): type fail Co-authored-by: Cheerego7 <48879533+Cheerego7@users.noreply.github.com> Co-authored-by: Leo <1826234293@qq.com> Co-authored-by: hyrious <hyrious@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.