Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds project structure details and next steps #24

Merged
merged 3 commits into from May 24, 2022
Merged

Conversation

maxcell
Copy link
Contributor

@maxcell maxcell commented May 20, 2022

Summary

Here's a good start for us on what we could include for the project structure, how to make changes, and where folks could go next.

Definitely open to feedback on if it is too much or too little!

Relevant Issues

@maxcell maxcell requested review from tzmanics and taty2010 May 20, 2022 16:10
@taty2010
Copy link
Contributor

Should we also reference the "How to use this theme" page within the project? That page seems to have a good breakdown of what other tools can be used.
/how-to-use/

@tzmanics
Copy link
Contributor

This is really fantastic, honestly when I wrote that issue i couldn't wrap my brain around how to structure this and this is great!

The only two things i would add are 1. Tatyana's suggestion of linking to the how to use page in the bottom section and 2. a section on how to change the homepage via src/pages/index.js, just like the great header and footer sections and maybe a specific nod to part of it like the hero component

        {/* Hero Container */}
        <Hero 
          maxWidth={'500px'}
          image={'/banner1.png'} 
          title={'Essentials for a cold winter'} 
          subtitle={'Discover Autumn Winter 2021'}
          ctaText={'shop now'}
          ctaAction={goToShop}
        />

{/* Hero Container */}

Other than that i'd say ship this gem!

@maxcell maxcell self-assigned this May 23, 2022
Copy link
Contributor

@tzmanics tzmanics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks perrfect

Copy link
Contributor

@taty2010 taty2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!!

@maxcell maxcell merged commit 5b5d9b8 into main May 24, 2022
@maxcell maxcell deleted the pw/1/deepDive branch May 24, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add dive deeper section to readme
3 participants