NETLIFY_SITE_ID secret issue in monorepos

[suancarloj]

Hello,

I just noticed that when I tried to build a monorepo workflow I could not set two different NETLIFY_SITE_ID secret, how was it handle in this video https://vimeo.com/295659187 ?
I'm tempted to use a simple env var but I don't know what the risk is of saving the netlify site id in the git repo.

workflow "Build and deploy frontend on push" {
  on = "push"
  resolves = ["Publish app", "Publish admin"]
}

action "Check files app" {
  uses = "netlify/actions/diff-includes@master"
  args = "app"
}

// This will only be run if there are changes in docs directory in the last set
// of commits pushed
action "Publish app" {
  needs = "Check files app"
  uses = "netlify/actions/build@master"
  // see https://github.com/netlify/actions/tree/master/build for details
  secrets = ["GITHUB_TOKEN", "NETLIFY_SITE_ID"]
  env = {
    BUILD_DIR = "app"
  }
}

action "Check files admin" {
  uses = "netlify/actions/diff-includes@master"
  args = "admin"
}

// This will only be run if there are changes in docs directory in the last set
// of commits pushed
action "Publish admin" {
  needs = "Check files admin"
  uses = "netlify/actions/build@master"
  // see https://github.com/netlify/actions/tree/master/build for details
  secrets = ["GITHUB_TOKEN", "NETLIFY_SITE_ID"]
  env = {
    BUILD_DIR = "admin"
  }
}

[kitop]

Hi @suancarloj

The way secrets are handled changed since the demo (it's much better now!), but unfortunately that means the demo is no longer fully accurate.

You should be able to use env variables for NETLIFY_SITE_ID and store it in your repo, it's not unsafe at all. Just make sure to never expose any access token :)

[suancarloj]

@kitop Awesome, exactly what I ended up doing, just wanted the confirmation :-D that it was safe! Thank you so much !