Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type errors due to missing failPLugin function #87

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

JGAntunes
Copy link
Member

Internal error that just showed up in our alerting, we're not passing over the failPlugin function to the utils methods. See related thread:

Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for plugin-angular-universal-demo ready!

Name Link
🔨 Latest commit 4e3aa51
🔍 Latest deploy log https://app.netlify.com/sites/plugin-angular-universal-demo/deploys/6561135614dcdb00088a1e65
😎 Deploy Preview https://deploy-preview-87--plugin-angular-universal-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JGAntunes JGAntunes self-assigned this Nov 24, 2023
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Nov 24, 2023
@Skn0tt
Copy link
Contributor

Skn0tt commented Nov 27, 2023

Looks good! Thanks for adding those tests <3

@Skn0tt Skn0tt merged commit db09d04 into main Nov 27, 2023
12 of 14 checks passed
@JGAntunes JGAntunes deleted the fix/fail-plugin branch November 27, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants