Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

add Yarn to build-image #25

Closed
fool opened this issue Oct 17, 2016 · 4 comments
Closed

add Yarn to build-image #25

fool opened this issue Oct 17, 2016 · 4 comments
Assignees

Comments

@fool
Copy link
Contributor

fool commented Oct 17, 2016

https://github.com/yarnpkg/yarn

@fool
Copy link
Contributor Author

fool commented Oct 17, 2016

while you're in there, it would be awesome to get #24 and #22 handled as well @rybit :)

@t-richards
Copy link

t-richards commented Oct 21, 2016

Arguably, the most important feature of yarn is that it installs dependencies over 9000% faster than npm. Unfortunately, due to the fact that npm install is run automatically by run-build.sh, it kind of defeats the purpose of having yarn available in the first place, IMO.

It would be nice to have some way to opt-out of this default behavior. Maybe an environment variable SKIP_NPM=true that would tell run-build.sh to skip the npm install portion of the script?

I'd be happy to write up a PR if you're willing to entertain this as a possibility.

@biilmann
Copy link
Member

Our plan with YARN is to use it instead of npm install whenever we detect a yarn.lock file

@hhsnopek
Copy link
Contributor

hhsnopek commented Nov 1, 2016

Ayye! This added a couple days ago in 449895f 😄

@fool fool closed this as completed Dec 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants