Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins to access specific secret environment variables #193

Closed
ehmicky opened this issue Oct 4, 2019 · 1 comment
Closed

Allow plugins to access specific secret environment variables #193

ehmicky opened this issue Oct 4, 2019 · 1 comment
Labels

Comments

@ehmicky
Copy link
Contributor

ehmicky commented Oct 4, 2019

From #68, we have the following proposed syntax:

plugins:
  pluginOne:
    # secrets by key
    secrets: # accessible by this
      - MY_SECRET_KEY

This means we are passing this environment variable to the plugins, correct? This would require plugins to be run in child processes (see #168).

What about the other environment variables? How do we know which one should be passed or not to the plugin child process?

@ehmicky
Copy link
Contributor Author

ehmicky commented Feb 26, 2020

Merged to #842.

@ehmicky ehmicky closed this as completed Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant