Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some test snapshots cannot be updated #3615

Closed
ehmicky opened this issue Sep 15, 2021 · 1 comment · Fixed by #3616
Closed

Some test snapshots cannot be updated #3615

ehmicky opened this issue Sep 15, 2021 · 1 comment · Fixed by #3616
Assignees
Labels
type: chore work needed to keep the product and development running smoothly

Comments

@ehmicky
Copy link
Contributor

ehmicky commented Sep 15, 2021

ava -u refuses to update the snapshots of some test files:

$ ava -u packages/build/tests/log/tests.js 
Could not update snapshots for the following test files:
⚠ packages/build/tests/log/tests.js

The problem is due to test.skip() being incompatible with ava -u: avajs/ava#2634
This was fixed in this PR: avajs/ava#2685
However the PR will be released with Ava v4, which is still in alpha.

In the meantime, we should comment those tests out instead of using test.skip().

@ehmicky ehmicky added the type: chore work needed to keep the product and development running smoothly label Sep 15, 2021
@ehmicky ehmicky self-assigned this Sep 15, 2021
@ehmicky
Copy link
Contributor Author

ehmicky commented Sep 15, 2021

Fixed at #3616

@kodiakhq kodiakhq bot closed this as completed in #3616 Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant