feat!: drop node 12 support for plugin execution #4741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
reviewed
Dec 5, 2022
| /** | ||
| * @deprecated will be replaced with `MINIMUM_REQUIRED_NODE_VERSION` at the 5th. of December 2022 | ||
| */ | ||
| const OLD_MINIMUM_REQUIRED_NODE_VERSION = '^12.20.0 || ^14.14.0 || >=16.0.0' | ||
| /** | ||
| * This node version is minimum required to run the plugins code. | ||
| * If the users preferred Node.js version is below that we have to fall back to the system node version |
There was a problem hiding this comment.
Let's hope that everything works, as everywhere we dropped < 4.16 but here we allow >= 4.14. I know why we did this, but just saying this is something we should keep an eye on.
|
Should we have a FF to turn this on/off just to be safe? |
I think this is not necessary as we communicated this change upfront and support reached out to individual customers about that. Would be off if we then revert it once we released it. |
lukasholzer
deleted the
feat/dropping-node-12-support-for-plugin-execution
branch
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes https://github.com/netlify/pillar-workflow/issues/955
Doing the node 12 support drop for the plugins execution based on our forums announcement.
See more details here: https://www.notion.so/netlify/Node-Versions-with-Plugins-55e9c5eb9c5f48d88c2f5925d9035b28
follow up based on: https://github.com/netlify/pillar-workflow/issues/968
cc @kitop @gualterandre @fool
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)