feat: inline stage 2 ESZIP bundler #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
added
the
type: feature
eduardoboucas
commented
Aug 22, 2022
| @@ -0,0 +1,47 @@ | |||
| import { load } from "https://deno.land/x/eszip@v0.18.0/loader.ts"; | |||
There was a problem hiding this comment.
This file was copied untouched from the edge bootstrap repo.
Some of the functions here are used by the edge bootstrap when generating the stage 1 ESZIP. We can live with the duplicated code for now, and later on we can change edge bootstrap so that the files are loaded from this repo instead. Conceptually, it makes more sense for the bootstrap to load bundling logic from the bundler repo than the other way around.
| @@ -0,0 +1,4 @@ | |||
| export const PUBLIC_SPECIFIER = "netlify:edge"; | |||
There was a problem hiding this comment.
This file was copied untouched from the edge bootstrap repo.
| @@ -0,0 +1,81 @@ | |||
| import { build, LoadResponse } from 'https://deno.land/x/eszip@v0.18.0/mod.ts' | |||
There was a problem hiding this comment.
This file was copied untouched from the edge bootstrap repo.
EwanValentine
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this pull request solving?
When bundling an edge function with the ESZIP format, Edge Bundler is fetching some logic from the edge bootstrap in order to generate the stage 2 file. In reality, this logic has very little to do with the bootstrap layer itself and is actually concerned with bundling, so it makes sense to move it to Edge Bundler.
By moving it, we're also reducing the number of network calls we need to make at build time, which are causing occasional errors.