feat: add tests for serve functionality
#116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
EwanValentine
previously approved these changes
Sep 14, 2022
|
Looks good, looks like the Windows tests are failing in the most vague way possible, though |
eduardoboucas
requested changes
Sep 14, 2022
test/serving.ts
Outdated
| const fixturesDir = resolve(dirname, '..', 'fixtures') | ||
|
|
||
| test.serial('bundler serving functionality', async (t) => { | ||
| const PORT_THATS_HOPEFULLY_FREE = 5832 |
There was a problem hiding this comment.
Can we call this port?
Also, should we use something like https://www.npmjs.com/package/get-port rather than hardcoding a port and hoping that it's free?
There was a problem hiding this comment.
good call, yeah :D done in 709cc70
I think that's unrelated to this PR, see https://netlify.slack.com/archives/C0359548J07/p1663067013856019 |
eduardoboucas
previously approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Nice one! You might need to move the test file to test/node/ if #122 is merged first.
eduardoboucas
changed the title
serve functionalityserve functionality
eduardoboucas
approved these changes
Sep 20, 2022
Skn0tt
changed the title
serve functionalityserve functionality
github-actions
bot
added
the
type: feature
Skn0tt
added a commit
to netlify/build
that referenced
this pull request
Apr 23, 2024
* chore: add test for `serve` * chore: remove unneeded `await` * chore: try 0.0.0.0 * refactor: use getPort * refactor: move files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serveawaitCloses https://github.com/netlify/pod-compute/issues/103.