Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add functions level to metadata object #129

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Conversation

eduardoboucas
Copy link
Member

Follow up to #122 and #126, which haven't been released yet (see #125). It changes the shape of the metadata object to have function-specific metadata under a functions key.

Before:

export const metadata = {
  func1: {
    url: "file:///some/path/func1.ts"
  },
  func2: {
    url: "file:///some/path/func2.ts"
  }
}

After:

export const metadata = {
  functions: {
    func1: {
      url: "file:///some/path/func1.ts"
    },
    func2: {
      url: "file:///some/path/func2.ts"
    }
  }
}

This will allow us to more easily export additional metadata that is not tied to a specific function (e.g. the path of the stage 2 file).

@eduardoboucas eduardoboucas added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Sep 16, 2022
@eduardoboucas eduardoboucas requested a review from a team September 16, 2022 14:14
@eduardoboucas eduardoboucas merged commit 45cf3b2 into main Sep 19, 2022
@eduardoboucas eduardoboucas deleted the feat/metadata-shape branch September 19, 2022 10:42
Skn0tt pushed a commit to netlify/build that referenced this pull request Apr 23, 2024
…r#129)

* feat: add `functions` level to `metadata` object

* chore: use file URL in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants