Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get config in server mode #175

Merged
merged 2 commits into from
Oct 28, 2022
Merged

feat: get config in server mode #175

merged 2 commits into from
Oct 28, 2022

Conversation

eduardoboucas
Copy link
Member

Which problem is this pull request solving?

To make in-source configuration work with the CLI, we need to parse the function config when in server mode. This PR enables that.

@eduardoboucas eduardoboucas added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Oct 27, 2022
@eduardoboucas eduardoboucas requested a review from a team October 27, 2022 15:25
const success = await waitForServer(port, processRef.ps)

return {
functionsConfig,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the new property that the CLI will start reading.

@eduardoboucas eduardoboucas merged commit ea47d4e into main Oct 28, 2022
@eduardoboucas eduardoboucas deleted the feat/isc-server branch October 28, 2022 11:21
Skn0tt pushed a commit to netlify/build that referenced this pull request Apr 23, 2024
* chore: move test

* feat: read function config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants