Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add layer: prefix to ESZIP loader #201

Merged
merged 4 commits into from
Nov 17, 2022
Merged

feat: add layer: prefix to ESZIP loader #201

merged 4 commits into from
Nov 17, 2022

Conversation

eduardoboucas
Copy link
Member

This should've been part of #198, but I forgot. We need to tell the ESZIP loader to treat any specifiers that start with layer: as dangling imports.

@eduardoboucas eduardoboucas added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Nov 17, 2022
@eduardoboucas eduardoboucas requested a review from a team November 17, 2022 11:01
Skn0tt
Skn0tt previously approved these changes Nov 17, 2022
@eduardoboucas
Copy link
Member Author

@Skn0tt I realised I was missing the layers property in the bundle entry point. Also added a new test. Could I get another ✅, please? 🙏🏻

@eduardoboucas eduardoboucas requested review from Skn0tt and a team November 17, 2022 13:05
@khendrikse khendrikse merged commit 4d0e8dd into main Nov 17, 2022
@khendrikse khendrikse deleted the feat/layer-loader branch November 17, 2022 13:56
Skn0tt pushed a commit to netlify/build that referenced this pull request Apr 23, 2024
* feat: add `layer:` prefix to ESZIP loader

* feat: add layer support to ESZIP loader

* refactor: ensure ESZIP path exists

Co-authored-by: Karin Hendrikse <30577427+khendrikse@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants