Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add manifest validation #208

Merged
merged 3 commits into from
Nov 21, 2022
Merged

feat: add manifest validation #208

merged 3 commits into from
Nov 21, 2022

Conversation

danez
Copy link
Contributor

@danez danez commented Nov 18, 2022

Moves the validation from @netlify/build to this repo.

It is pretty much a copy, except:

  • added new tests
  • changed bundle format to be an enum and also is validated as such
  • uses better-ajv-errors for pretty printed errors (PR to remove emojis)
  • initializes ajv lazy

netlify/build#4710

Copy link
Member

@Skn0tt Skn0tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@kodiakhq kodiakhq bot merged commit 17ee035 into main Nov 21, 2022
@kodiakhq kodiakhq bot deleted the validation branch November 21, 2022 10:07
Skn0tt pushed a commit to netlify/build that referenced this pull request Apr 23, 2024
* feat: add manifest validation

* chore: disable color in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants