fix: deep merge in source and toml config #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node/declaration.ts
Outdated
|
|
||
| if (path) { | ||
| if (config) { |
There was a problem hiding this comment.
I don't think the else branch will ever be reached, because config has a fallback value of ??. This wasn't the case before, since we were checking the path property specifically.
Or am I holding it wrong?
There was a problem hiding this comment.
That's true, I'll remove the if/else altogether, functionsVisited should still get populated accurately at this point.
eduardoboucas
approved these changes
Nov 23, 2022
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
Apr 23, 2024
* fix: deep merge in source and toml config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帀 Thanks for sending this pull request! 馃帀
Please make sure the title is clear and descriptive.
If you are fixing a typo or documentation, please skip these instructions.
Otherwise please fill in the sections below.
Which problem is this pull request solving?
Example: I'm always frustrated when [...]
List other issues or pull requests related to this problem
This relates to https://github.com/netlify/pod-compute/issues/292
Describe the solution you've chosen
Example: I've fixed this by [...]
Describe alternatives you've considered
Example: Another solution would be [...]
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)