Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add importMapPaths to bundle and serve #265

Merged
merged 6 commits into from
Dec 19, 2022

Conversation

eduardoboucas
Copy link
Member

@eduardoboucas eduardoboucas commented Dec 19, 2022

Which problem is this pull request solving?

This is the final (🤞🏻) PR related to import maps! I'm sorry that it's a bit large, but it accomplishes a couple of things:

  1. Change the approach introduced in feat!: add support for user-defined import maps #256, so that instead of reading a Deno config file we accept an array of paths to import maps that are to be supplied by Netlify Build (more details here)
  2. Add support for import map scopes
  3. Add a runESZIP test util that actually extracts the generated ESZIP, invokes the functions inside, and asserts the output.

@eduardoboucas eduardoboucas added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Dec 19, 2022
@eduardoboucas eduardoboucas requested a review from a team December 19, 2022 11:27
@eduardoboucas eduardoboucas merged commit dcbd7f7 into main Dec 19, 2022
@eduardoboucas eduardoboucas deleted the feat/import-map-paths branch December 19, 2022 12:15
Skn0tt pushed a commit to netlify/build that referenced this pull request Apr 23, 2024
…dler#265)

BREAKING CHANGE: Both `bundle` and `serve` now expect an `importMapPaths` array containing a list of paths to any user-defined import map files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants