feat: validate pattern declarations #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
added
the
type: feature
danez
previously approved these changes
Feb 2, 2023
node/manifest.ts
Outdated
| throw new Error( | ||
| `Could not parse path declaration of function '${declaration.function}': ${(error as Error).message}`, | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| return pathToRegularExpression(declaration.path) | ||
| } | ||
|
|
||
| const getExcludedRegularExpression = (declaration: Declaration) => { | ||
| if ('pattern' in declaration && declaration.excludedPattern) { |
There was a problem hiding this comment.
Suggested change
| if ('pattern' in declaration && declaration.excludedPattern) { | |
| if ('excludedPattern' in declaration && declaration.excludedPattern) { |
Not really a change from this PR but seems it is currently wrong/broken? But I might be wrong and we only return the excludePattern when there is a pattern?
There was a problem hiding this comment.
Good catch! Fixed in 51d1023.
ascorbic
reviewed
Feb 2, 2023
node/declaration.ts
Outdated
| Assertion(path) { | ||
| // Lookaheads are not supported. If we find one, throw an error. | ||
| if (path.node.kind === 'Lookahead') { | ||
| throw new Error('Regular expressions with negative lookaheads are not supported') |
There was a problem hiding this comment.
It's not just negative lookaheads that aren't supported: positive lookaheads aren't either.
There was a problem hiding this comment.
Ah-ha! The comment was correct but the error message was not. Fixed in 2efa3f8.
danez
approved these changes
Feb 2, 2023
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
Apr 23, 2024
* feat: validate pattern declarations * refactor: change import * chore: add comment * fix: add missing call to `serializePattern` * refactor: wrap call to `parsePattern` * refactor: update error message * fix: look for `excludedPattern`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this pull request solving?
This PR parses into an AST any paths defined as regular expressions and:
List other issues or pull requests related to this problem
Supersedes #226.