feat: allow setting environment variables and disable extending in DenoServer #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
added
the
type: feature
|
Okay I finally managed to add some tests. This is ready to review. |
Skn0tt
reviewed
Aug 4, 2022
| @@ -31,6 +31,8 @@ interface ProcessRef { | |||
|
|
|||
| interface RunOptions { | |||
| pipeOutput?: boolean | |||
| env?: NodeJS.ProcessEnv | |||
| extendEnv?: boolean | |||
There was a problem hiding this comment.
In what case would we set extendEnv to true? Or is this for backwards compatibility?
There was a problem hiding this comment.
The default value is true atm. I was hardcoding this at first, but then wondered if runInBackground might be used in other scenarios in the future. Do you think I should hardcode this to false?
And because run does the same, besides the background part I also added the options there.
eduardoboucas
previously approved these changes
Aug 8, 2022
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
eduardoboucas
previously approved these changes
Aug 8, 2022
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
eduardoboucas
approved these changes
Aug 8, 2022
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
Apr 23, 2024
…noServer (netlify/edge-bundler#82) * feat: allow setting environment variables and disable extending in DenoServer * chore: fix test * chore: fix tests * chore: add test * chore: debug * chore: fix tests * chore: fix tests? * Update test/bridge.ts Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com> * Update src/server/server.ts Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com> Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for netlify/cli#4614.
The PR allows setting environment variables in
deno.runanddeno.runInBackgroundas well as disabling extending of current runtime environment variables. These two options basically are plainexecaoptions, which are forwarded to execa.I disabled the extending of env variables in the DenoServer so that once the CLI sets the variables it will be only those available in deno. With the exception of
DENO_DIR.DENO_DIRis okay to have locally?