Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

fix!: Drop Node 12 support #33

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Conversation

jackiewmacharia
Copy link
Contributor

馃帀 Thanks for sending this pull request! 馃帀

Please make sure the title is clear and descriptive.

If you are fixing a typo or documentation, please skip these instructions.

Otherwise please fill in the sections below.

Which problem is this pull request solving?

Example: I'm always frustrated when [...]

List other issues or pull requests related to this problem

Example: This fixes #5012

Describe the solution you've chosen

Example: I've fixed this by [...]

Describe alternatives you've considered

Example: Another solution would be [...]

Checklist

Please add a x inside each checkbox:

  • I have read the contribution guidelines.
  • The status checks are successful (continuous integration). Those can be seen below.

A picture of a cute animal (not mandatory but encouraged)

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Oct 16, 2022
@jackiewmacharia jackiewmacharia changed the title fix: Drop Node 12 support fix!: Drop Node 12 support Oct 16, 2022
Copy link

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the GitHub workflow should be updated and test with node 14 instead of 12.

package.json Outdated Show resolved Hide resolved
@jackiewmacharia jackiewmacharia merged commit a9b2ad9 into main Oct 19, 2022
@jackiewmacharia jackiewmacharia deleted the fix/drop-node-12-support branch October 19, 2022 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants