Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signup data argument is required by typescript #159

Closed
MatthewPardini opened this issue Sep 6, 2020 · 1 comment · Fixed by #165
Closed

signup data argument is required by typescript #159

MatthewPardini opened this issue Sep 6, 2020 · 1 comment · Fixed by #165
Labels
area: api: signup area: types released type: bug code to address defects in shipped code

Comments

@MatthewPardini
Copy link

MatthewPardini commented Sep 6, 2020

Describe the bug
When using gotrue-js with typescript, an error occurs when following documentation for using .signup(). The docs show only two required arguments, however the final data argument is required.

To Reproduce

  1. install typescript
  2. instantiate new GoTrue object
  3. try to use .signup() with only two arguments (email, password) omitting a data object.
  4. see error

Expected behavior
The final argument is expected to be optional because 1) it is not required and 2) the documentation shows this

Desktop (please complete the following information):

  • OS: macOS
  • Browser [e.g. chrome, safari]: chromium engine 12.16.13 via electron 10.1.1
@erezrokah
Copy link
Contributor

🎉 This issue has been resolved in version 0.9.27 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: api: signup area: types released type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants