Skip to content
This repository has been archived by the owner on Oct 10, 2022. It is now read-only.

Feature: Support specifying commit sha/URL when creating/updating a deploy #149

Open
erezrokah opened this issue Sep 10, 2020 · 2 comments
Labels
area: api type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@erezrokah
Copy link
Contributor

Related to netlify/cli#1122

- Do you want to request a feature or report a bug?

Feature

- What is the current behaviour?

Manual deploys shown in the Netlify UI are not linked to any commit.

- What is the expected behaviour?

An option should be provider to tag a deploy with a commit sha or URL so one could click the deploy in the Netlify UI and be redirected to the relevant commit in the repo.

- Possible workaround

Use the message argument, but that doesn't create a link in the UI

@erezrokah erezrokah added type: feature code contributing to the implementation of a feature and/or user facing functionality area: api labels Sep 10, 2020
@ingride
Copy link
Contributor

ingride commented Sep 10, 2020

The deploy object has the following attributes we would need to expose and receive

Commit details:

    attributes[:commit_ref] # this is the actual sha
    attributes[:committer_slug] # the commiter slug
    attributes[:committer_name] # the commiter name if set

PR details:

   attributes[:review_id] # PR number - example: 123
   attributes[:review_url] # PR URL - example https://github.com/netlify/js-client/pull/123"

I think this becomes a matter of making those available in the Open-API and passing them in when creating a deploy.

@tinfoil-knight
Copy link

@ingride Are there any plans for adding this to the Netlify OpenAPI?

I'll pick up the related changes for the js-client & cli repo then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: api type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

No branches or pull requests

3 participants