Skip to content
This repository has been archived by the owner on Oct 10, 2022. It is now read-only.

Return the whole response object from the methods #287

Open
JGAntunes opened this issue Jan 22, 2021 · 1 comment
Open

Return the whole response object from the methods #287

JGAntunes opened this issue Jan 22, 2021 · 1 comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@JGAntunes
Copy link
Member

The current js-client API implementation is restrictive in the sense that it only exposes the response body and an error if that's the case. Coming from discussions in #285 #39 #156 I feel like it would make sense and there's enough room to add some sort of support for our methods to return the whole response object.

I realise this could easily be a breaking change, but maybe we could come up with a strategy where that wouldn't be the case?

@JGAntunes JGAntunes added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jan 22, 2021
@JGAntunes JGAntunes changed the title Return the response object from the methods Return the whole response object from the methods Jan 22, 2021
@erezrokah
Copy link
Contributor

I agreed we should return a more descriptive object.

We could support pagination in a non breaking way by letting users pass another argument like retreiveAll or something similar, but that feels like a hack.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

No branches or pull requests

2 participants