Skip to content
This repository has been archived by the owner on Oct 10, 2022. It is now read-only.

URL parameters should be percent-encoded #404

Open
ehmicky opened this issue Apr 29, 2021 · 2 comments
Open

URL parameters should be percent-encoded #404

ehmicky opened this issue Apr 29, 2021 · 2 comments
Labels
type: bug code to address defects in shipped code

Comments

@ehmicky
Copy link
Contributor

ehmicky commented Apr 29, 2021

URL parameters should be percent-encoded using encodeURIComponent().

return url.replace(`{${name}}`, value)

This fix should be a major release, since some clients might currently do this percent-encoding themselves. This is the case for example of @netlify/build with the updatePlugin endpoint at netlify/build#2700 (which would need to be fixed).

@Pentatool15

This comment has been minimized.

@Pentatool15

This comment has been minimized.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

No branches or pull requests

2 participants