Skip to content
This repository has been archived by the owner on Oct 10, 2022. It is now read-only.

draft property not being returned in listSiteDeploys #571

Open
GonzaloHirschToptal opened this issue Nov 12, 2021 · 0 comments
Open

draft property not being returned in listSiteDeploys #571

GonzaloHirschToptal opened this issue Nov 12, 2021 · 0 comments

Comments

@GonzaloHirschToptal
Copy link

Hi, we have a feature that depends on knowing whether or not a deploy was a draft. The listSiteDeploys docs for the api state that the draft property would be sent in the response, but our responses from the API are lacking that property.

We are using this client to consume the API from a Node application. I also created an issue in the API repo in case it's not something on this client's side.

Sample response:

{
      "id":"618c1336ed517213e60df2db",
      "site_id":REDACTED,
      "build_id":"618c1336ed517213e60df2d9",
      "state":"error",
      "name":"sandbox-straightforward-toad-618bcff9885ea2ecc10cb733",
      "url":REDACTED,
      "ssl_url":REDACTED,
      "admin_url":REDACTED,
      "deploy_url":REDACTED,
      "deploy_ssl_url":REDACTED,
      "created_at":"2021-11-10T18:45:10.571Z",
      "updated_at":"2021-11-10T18:45:13.601Z",
      "user_id":REDACTED,
      "error_message":"SOME ERROR NOT RELATED TO THIS",
      "required":[
         
      ],
      "required_functions":null,
      "commit_ref":null,
      "review_id":null,
      "branch":"main",
      "commit_url":null,
      "skipped":null,
      "locked":null,
      "log_access_attributes":{
         REDACTED
      },
      "title":null,
      "review_url":null,
      "published_at":null,
      "context":"production",
      "deploy_time":null,
      "available_functions":[
         
      ],
      "screenshot_url":null,
      "site_capabilities":{
        REDACTED
      },
      "committer":null,
      "skipped_log":null,
      "manual_deploy":false,
      "file_tracking_optimization":true,
      "plugin_state":"none",
      "has_edge_handlers":false,
      "links":{
         REDACTED
      },
      "framework":"not_fetched",
      "entry_path":null,
      "views_count":null
   }

BUG REPORT INFORMATION

- Do you want to request a feature or report a bug?
This is a bug.

- What is the current behavior?
The draft property is not being returned in the listSiteDeploys endpoint.

- If the current behavior is a bug, please provide the steps to reproduce.

  1. Create a deploy
  2. List the deploys

- What is the expected behavior?
draft property should be in the returned object.

- Please mention your node.js, and operating system version.
Node: v15.14.0
OS: MacOS 12.0.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant