Skip to content
This repository has been archived by the owner on Oct 10, 2022. It is now read-only.

regression: createSiteinTeam call returning 404 suddenly #697

Open
fool opened this issue Apr 5, 2022 · 1 comment
Open

regression: createSiteinTeam call returning 404 suddenly #697

fool opened this issue Apr 5, 2022 · 1 comment
Labels
blocked regression type: bug code to address defects in shipped code

Comments

@fool
Copy link
Contributor

fool commented Apr 5, 2022

(Enterprise) Customer who regularly uses this call via this library has begun receiving 404 / Not found responses as of 2022-03-31T12:45:24.408-04:00 ; last successful POST was 2022-03-31T13:09:45.552-04:00.

There is an example body which causes the failure and some proof that the createSiteinTeam call still works, albeit not when run via the js client. Netlify employees can see those details in https://netlify.zendesk.com/agent/tickets/88934

This seems to happen with various nodejs versions and I am guessing something perhaps changed in the open-api which the client just needs an upgrade for? Hopefully the timestamps can help you narrow things down.

@fool fool added type: bug code to address defects in shipped code regression blocked labels Apr 5, 2022
@fool
Copy link
Contributor Author

fool commented Apr 5, 2022

@eric-silverman and I talked a bit more about this in DM's. Next steps for customer:

  • try upgrading from v4.9 to current v11.0.1
  • review data - Eric is pretty sure (and I am inclined to agree) that this is a data issue. I do still think "something" changed on our side (though maybe something they configured: maybe their team membership (I see @RTakes all over their audit logs - cf https://app.netlify.com/teams/teespring-engineering/log?page=1) or team name or something - that led to us not doing a proper account lookup for this API call so we see a 404 instead of a 401 unauthorized).

They've already worked around the problem using the API directly as far as I heard, and I don't want to debug ancient version sooner - so let's call this blocked for now and should the customer re-engage, Support will follow up and put in backend pairing (or re-escalate to the pillar).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked regression type: bug code to address defects in shipped code
Projects
None yet
Development

No branches or pull requests

1 participant