Fix list item reordering #437

[Dammmien]

- Summary
Fix list item reordering. As explain in the issue #437.

- Test plan
In the example project:

• Open the authors entry in the settings collection
• Update the author descriptions to be distinct
  ( editor have to be on visual mode, markdown disabled )
• Reorder the authors
• Check the descriptions
• Before, the descriptions wasn't correctly updated, now it should be correct.

- Description for the changelog
After component did update, check the editor content is the same that the state value.
If it isn't the same, reset the state using a mutualized createState method.
I think it isn't the cleanest way to fix this bug.
It's better than nothing but if you have any other idea ...

[erquhart]

Thanks for this!

I think it isn't the cleanest way to fix this bug.
It's better than nothing

My thoughts exactly. The visual editor is coming to the end of a rewrite, so I have no problem merging this for now.

[erquhart]

LGTM

[Benaiah]

Given that this is a temporary fix, this LGTM. My only suggestion might be to add a comment in the code explaining why this is being done, so it's not refactored away by a well-meaning contributor. That's a low risk, though, so IMO it's fine either way.

[erquhart]

That's a good point - @Dammmien would you mind adding a comment in the new lifecycle method explaining it's purpose? Then we're good to merge.

[Dammmien]

Done @erquhart !

[erquhart]

Thanks!